Add signbit and fix argmin and argmax
#20821
Merged
+212
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20821 +/- ##
==========================================
+ Coverage 82.01% 82.03% +0.02%
==========================================
Files 559 559
Lines 52291 52367 +76
Branches 8084 8096 +12
==========================================
+ Hits 42884 42961 +77
+ Misses 7431 7428 -3
- Partials 1976 1978 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We need to fix the version of torch until torch-xla supports a higher version. In this PR, the testing env is:
|
fchollet
approved these changes
Jan 29, 2025
keras/src/backend/jax/numpy.py
Outdated
| @@ -15,6 +16,14 @@ | |||
| from keras.src.backend.jax.core import convert_to_tensor | |||
|
|
|||
|
|
|||
| def jax_uses_cpu(): | |||
There was a problem hiding this comment.
Please move this to keras/src/testing/test_case.py. We can also have corresponding functions for other backends if needed.
There was a problem hiding this comment.
Sure! I have added uses_cpu() to test_case.py
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
the
ready to pull
fchollet
approved these changes
Jan 30, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this issue jax-ml/jax#24280, we should patch
argminandargmaxops only when using the CPU due to the flush-to-zero (FTZ) issue.Since we need
signbitto patch these ops, adding it is straightforward.