Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convnext to work with any custom input tensors #20854

Merged

Conversation

Inquisitive-ME
Copy link
Contributor

Convnext fails with custom inputs that are more than 1 layer, it looks like a bug. I added a test that highlights the problem and fails for all Convnext and then fixed the issue.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (b0fc0a3) to head (6cbfb54).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20854      +/-   ##
==========================================
+ Coverage   82.25%   84.87%   +2.62%     
==========================================
  Files         559      559              
  Lines       52374    52388      +14     
  Branches     8096     8102       +6     
==========================================
+ Hits        43079    44464    +1385     
+ Misses       7305     5794    -1511     
- Partials     1990     2130     +140     
Flag Coverage Δ
keras 84.69% <100.00%> (+2.62%) ⬆️
keras-jax 66.82% <100.00%> (+2.63%) ⬆️
keras-numpy 59.10% <0.00%> (+0.11%) ⬆️
keras-openvino 32.67% <0.00%> (+0.12%) ⬆️
keras-tensorflow 67.46% <100.00%> (+2.63%) ⬆️
keras-torch 66.78% <100.00%> (+2.62%) ⬆️
keras.applications 83.60% <100.00%> (?)
keras.applications-jax 83.60% <100.00%> (?)
keras.applications-numpy 22.81% <0.00%> (?)
keras.applications-openvino 22.81% <0.00%> (?)
keras.applications-tensorflow 83.60% <100.00%> (?)
keras.applications-torch 83.33% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please fix the code format (run sh shell/format.sh)

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Feb 5, 2025
@fchollet fchollet merged commit c49f487 into keras-team:master Feb 5, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants