-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix convnext to work with any custom input tensors #20854
Fix convnext to work with any custom input tensors #20854
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20854 +/- ##
==========================================
+ Coverage 82.25% 84.87% +2.62%
==========================================
Files 559 559
Lines 52374 52388 +14
Branches 8096 8102 +6
==========================================
+ Hits 43079 44464 +1385
+ Misses 7305 5794 -1511
- Partials 1990 2130 +140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Please fix the code format (run sh shell/format.sh
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Convnext fails with custom inputs that are more than 1 layer, it looks like a bug. I added a test that highlights the problem and fails for all Convnext and then fixed the issue.