-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenVINO backend]: Support numpy.bincount #20940
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20940 +/- ##
===========================================
- Coverage 82.43% 71.23% -11.21%
===========================================
Files 561 561
Lines 53205 53230 +25
Branches 8242 8245 +3
===========================================
- Hits 43862 37918 -5944
- Misses 7336 13331 +5995
+ Partials 2007 1981 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c249424
to
a26214f
Compare
Hii :)
|
have you tried testing locally? Does it work for you? |
yes everytime locally i run this command |
I had the same problem.
You can then test like this: |
if you want to fix a mistake in a file without doing a new commit you can do: git add keras/src/backend/openvino/numpy.py # after you fix the mistake in the file |
6e0aa84
to
97a087e
Compare
thanks for constantly helping me on this PR, I didnt knew about --force-with-lease I will try it next time, I currenlty did rebase while squashing all commits & force pushed it. |
fc1dac7
to
ac62d35
Compare
74167dd
to
78fe733
Compare
rebased fix: hardcode dtype int32 when weights=none Signed-off-by: 11happy <[email protected]> fix: use np.expand_dims Signed-off-by: 11happy <[email protected]> remove unecessary headers Signed-off-by: 11happy <[email protected]> style: reformat numpy_test.py Signed-off-by: 11happy <[email protected]>
faebd73
to
2b44541
Compare
x = knp.expand_dims(x, 0) | ||
weights = knp.expand_dims(weights, 0) | ||
x = np.expand_dims(x, 0) | ||
weights = np.expand_dims(weights, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier the openvino CI was failing because of this as in the implementation of expand_dims if input is not an instance of openvinokerastensor it was going in else statement causing a false assert.
@@ -95,6 +96,7 @@ NumpyOneInputOpsCorrectnessTest::test_argmin | |||
NumpyOneInputOpsCorrectnessTest::test_argpartition | |||
NumpyOneInputOpsCorrectnessTest::test_argsort | |||
NumpyOneInputOpsCorrectnessTest::test_array | |||
NumpyOneInputOpsCorrectnessTest::test_average | |||
NumpyOneInputOpsCorrectnessTest::test_bincount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you should only remove lines corresponding to bincount tests.
Now you are adding for average
for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, while resolving the merge conflict I took a merge with the master branch and it was an incoming change so I did kept a combination of both current and incoming, I will remove it.
Thank you
Overview:
Testing:
CC: