Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image registry option #18

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Nov 20, 2024

Description

Pull Request Title: Add image registry option

Description:

This pull request introduces the ability to specify a global image registry for all Docker images used in the Helm charts. The following changes were made:

  1. Chart Version Update:

    • Updated the chart version from 0.71.0 to 0.72.0 in charts/hub/Chart.yaml.
  2. Global Image Registry Addition:

    • Added a new global value imageRegistry in charts/hub/values.yaml to specify the Docker image registry (default set to "docker.io/").
  3. Template Modifications:

    • Updated all image references in various template files (hub-api.yaml, hub-cleanup.yaml, hub-frontend-demo.yaml, hub-frontend.yaml, hub-monitor-device.yaml, hub-reactivate-subscription.yaml, pipe-analysis.yaml, pipe-counting.yaml, pipe-dominantcolor.yaml, pipe-event.yaml, pipe-export.yaml, pipe-monitor.yaml, pipe-notify-test.yaml, pipe-notify.yaml, pipe-sequence.yaml, pipe-sprite.yaml, pipe-throttler.yaml, pipe-thumbnail.yaml, vault-forwarder.yaml, vault-proxy.yaml) to prepend the global image registry value.

Motivation:

The primary motivation behind this change is to enhance the flexibility and configurability of the Helm charts. By allowing a global image registry to be specified, users can easily switch between different Docker registries (e.g., Docker Hub, private registries) without modifying individual image references across multiple template files.

Benefits:

  • Centralized Configuration: Simplifies the process of changing the image registry by centralizing the configuration in the values.yaml file.
  • Flexibility: Provides the ability to easily switch between different Docker registries, facilitating better integration with various CI/CD pipelines and deployment environments.
  • Consistency: Ensures that all Docker image references are consistently prefixed with the specified image registry, reducing the risk of configuration errors.

This enhancement significantly improves the usability and maintainability of the Helm charts, making it easier for users to deploy the application in different environments with minimal configuration changes.

@cedricve cedricve self-assigned this Nov 20, 2024
@cedricve cedricve merged commit b62360f into main Nov 20, 2024
2 checks passed
@cedricve cedricve deleted the feature/add-global-image-registry branch November 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant