feat(LogSheet): Update UI of log download links #670
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new function `truncateUrl` used to truncate the URL in the log viewer - Changed the title of the download log table to "Full logs" - Changed the messaged of the QuerySwitcher to "Download your logs here" - Changed the style of the log links, making their font size greater and their color blue with an underline hover effect Closes #655
murilx
commented
Dec 11, 2024
| domainLength = 50, | ||
| endPathLength = 20, | ||
| ): string => { | ||
| if ('parse' in URL && url) { |
There was a problem hiding this comment.
If 'parse' not in URL (meaning the browser does not support this) but url is not undefined, the function should call truncateBigText so that the URL is not shown unprocessed. Other solution would be to refactor this function to always use native/supported JS functions like split('/')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
truncateUrlused to truncate the URL in the log viewerCloses #655
Visual Reference
Before
After
