feat: Remove default values from URL #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
force-pushed
the
feat/remove-default-values-url
branch
2 times, most recently
from
525eb27 to
aa6f0b3
Compare
WilsonNet
reviewed
Dec 11, 2024
| @@ -146,7 +163,8 @@ export const zTreeInformation = z | |||
| commitName: z.string().optional().catch(''), | |||
There was a problem hiding this comment.
another ticket for you, create a ticket to remove parameters that does not need to be in the URL
the URL is to remember user choices, this can be inferred from the sql query response
WilsonNet
reviewed
Dec 11, 2024
| const zHardwareSchema = z.object({ | ||
| intervalInDays: makeZIntervalInDays(DEFAULT_HARDWARE_INTERVAL_IN_DAYS), | ||
| hardwareSearch: z.string().optional().catch(undefined), | ||
| hardwareSearch: z.string().optional().catch(''), |
There was a problem hiding this comment.
from what I'm understanding with stripSerach poarameters you don't need .optional anymore
WilsonNet
reviewed
Dec 11, 2024
dashboard/src/routes/tree/route.tsx
Outdated
| export const RootSearchSchema = z.object({ | ||
| intervalInDays: makeZIntervalInDays(DEFAULT_TIME_SEARCH), | ||
| treeSearch: z.string().optional().catch(''), |
WilsonNet
reviewed
Dec 11, 2024
| const { isLoading, data, error } = useTreeDetails({ | ||
| treeId: treeId ?? '', | ||
| filter: reqFilter, | ||
| }); | ||
|
|
||
| const { tableFilter, diffFilter } = useSearch({ | ||
| from: '/tree/$treeId/', | ||
| from: '/tree/$treeId', |
There was a problem hiding this comment.
Why did you change this?
/ is suppose to be the leaf, and that is the more exact place in this current route
WilsonNet
reviewed
Dec 11, 2024
| @@ -35,14 +35,14 @@ interface TestsTabProps { | |||
| } | |||
|
|
|||
| const TestsTab = ({ reqFilter }: TestsTabProps): JSX.Element => { | |||
| const { treeId } = useParams({ from: '/tree/$treeId/' }); | |||
| const { treeId } = useParams({ from: '/tree/$treeId' }); | |||
murilx
force-pushed
the
feat/remove-default-values-url
branch
from
aa6f0b3 to
811eefb
Compare
- Added the search middleware `stripSearchParams` to remove search params with default values from the URL - Changed `from` options to use route instead of index e.g from `/tree/$treeId/` to `/tree/$treeId` - Added some default clauses to zod types to make the default values of search params be returned when they are stripped from the URL. Without this clause the returned value would be undefined Closes #656
murilx
force-pushed
the
feat/remove-default-values-url
branch
from
811eefb to
8c661c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripSearchParamsto remove search params with default values from the URLfromoptions to use route instead of index e.g from/tree/$treeId/to/tree/$treeIdCloses #656
How to test
Navigate through the app, verifying that default values aren't being shown in the URL while keeping the same behaviour. Also note that when changing something, the search params goes back to the URL.