feat: add status count in hardware tested #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
reviewed
Oct 22, 2024
WilsonNet
reviewed
Oct 22, 2024
anajalvarenga
force-pushed
the
feat/hardware-tested-counts
branch
from
75e10f3 to
bbf2149
Compare
WilsonNet
reviewed
Oct 23, 2024
| @@ -242,7 +242,7 @@ def __processBootsTest(self, currentRowData): | |||
| self.bootFailReasons[testError] = self.bootFailReasons.get(testError, 0) + 1 | |||
|
|
|||
| if testEnvironmentCompatible is not None: | |||
| self.bootEnvironmentCompatible[testEnvironmentCompatible] += 1 | |||
| self.bootEnvironmentCompatible[testEnvironmentCompatible][testStatus] += 1 | |||
There was a problem hiding this comment.
Some test status are coming as null nowadays, I whink we should acknowledge for them and count them
There was a problem hiding this comment.
I added this logic, calling null testStatus as none or NONE to avoid errors with null JavaScript
WilsonNet
reviewed
Oct 23, 2024
anajalvarenga
force-pushed
the
feat/hardware-tested-counts
branch
from
bbf2149 to
1c19cdd
Compare
WilsonNet
reviewed
Oct 24, 2024
| @@ -242,7 +242,10 @@ def __processBootsTest(self, currentRowData): | |||
| self.bootFailReasons[testError] = self.bootFailReasons.get(testError, 0) + 1 | |||
|
|
|||
| if testEnvironmentCompatible is not None: | |||
| self.bootEnvironmentCompatible[testEnvironmentCompatible] += 1 | |||
| if testStatus is None: | |||
| self.bootEnvironmentCompatible[testEnvironmentCompatible]["NONE"] += 1 | |||
There was a problem hiding this comment.
very nit: but you can call it "NULL"
| pass={PASS} | ||
| skip={SKIP} | ||
| none={NONE} | ||
| forceNumber={false} |
There was a problem hiding this comment.
You're passing "forceNumber" here but the GroupedTestStatus component doesn't use it.
WilsonNet
approved these changes
Oct 24, 2024
lfjnascimento
approved these changes
Oct 24, 2024
anajalvarenga
force-pushed
the
feat/hardware-tested-counts
branch
from
1c19cdd to
eed5777
Compare
anajalvarenga
force-pushed
the
feat/hardware-tested-counts
branch
from
eed5777 to
48badb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add status count in hardware tested
Before just show the amount of occorencies
