-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: issue details navigation #734
Conversation
c069e7c
to
db9d442
Compare
@@ -82,6 +107,7 @@ const IssueDetailsPage = (): JSX.Element => { | |||
getTestTableRowLink={getTestTableRowLink} | |||
onClickBuildFilter={onClickBuildFilter} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug that the page loses its state when changing the table filter, making the title in the top bar change and the breadcrumb to disappear. We had a similar problem before (you can see more here: #686)
I believe that would be solved by passing the state to the function that changes the table filter, like its being done in this function in the BuildDetails page:
const onClickFilter = useCallback( |
especially this line:
state: historyState, |
db9d442
to
3e5b38f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3e5b38f
to
4896abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on my tests
Adds
issue_version
to the return of buildDetails, testDetails, treeDetails and hardwareDetails endpointsAdds navigation from buildDetails and testDetails issueSection to issueDetails page
Adds navigation from the issuesList card to the issueDetails page through a new icon on the right
Refactors treeDetails and hardwareDetails breadcrumbs to be reusable
Adds reactive breadcrumb and topBar to issueDetails using navigation state
How to test:
Closes #592