Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: issue details navigation #734

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

MarceloRobert
Copy link
Collaborator

@MarceloRobert MarceloRobert commented Jan 7, 2025

Adds issue_version to the return of buildDetails, testDetails, treeDetails and hardwareDetails endpoints
Adds navigation from buildDetails and testDetails issueSection to issueDetails page
Adds navigation from the issuesList card to the issueDetails page through a new icon on the right
Refactors treeDetails and hardwareDetails breadcrumbs to be reusable
Adds reactive breadcrumb and topBar to issueDetails using navigation state

How to test:

Closes #592

@MarceloRobert MarceloRobert force-pushed the feat/issue-details-navigation branch 3 times, most recently from c069e7c to db9d442 Compare January 8, 2025 11:47
@MarceloRobert MarceloRobert marked this pull request as ready for review January 8, 2025 12:10
@MarceloRobert MarceloRobert self-assigned this Jan 8, 2025
@@ -82,6 +107,7 @@ const IssueDetailsPage = (): JSX.Element => {
getTestTableRowLink={getTestTableRowLink}
onClickBuildFilter={onClickBuildFilter}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug that the page loses its state when changing the table filter, making the title in the top bar change and the breadcrumb to disappear. We had a similar problem before (you can see more here: #686)

I believe that would be solved by passing the state to the function that changes the table filter, like its being done in this function in the BuildDetails page:

const onClickFilter = useCallback(

especially this line:

@MarceloRobert MarceloRobert force-pushed the feat/issue-details-navigation branch from db9d442 to 3e5b38f Compare January 9, 2025 14:06
Copy link
Collaborator

@Francisco2002 Francisco2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarceloRobert MarceloRobert force-pushed the feat/issue-details-navigation branch from 3e5b38f to 4896abf Compare January 9, 2025 17:55
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on my tests

@MarceloRobert MarceloRobert merged commit 36078c1 into main Jan 9, 2025
5 checks passed
@MarceloRobert MarceloRobert deleted the feat/issue-details-navigation branch January 13, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate to issue details page
3 participants