Fix: issue card count #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
reviewed
Jan 13, 2025
backend/kernelCI_app/utils.py
Outdated
| @@ -20,6 +20,9 @@ class Issue(TypedDict): | |||
| incidents_info: IncidentInfo | |||
|
|
|||
|
|
|||
| IssueDict = Dict[Tuple[str, str], Issue] | |||
There was a problem hiding this comment.
lets use the typemodels folder for shared types
MarceloRobert
force-pushed
the
fix/issues-card-count
branch
3 times, most recently
from
2ef3b91 to
6b809d4
Compare
Closes #728
MarceloRobert
force-pushed
the
fix/issues-card-count
branch
from
6b809d4 to
f004716
Compare
Francisco2002
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should_filter_test_issueThere were tests which were related to a build that had an issue, and since the test failed, there were the right conditions to think that the issue should be incremented in the test issue list. Failed or inconclusive builds with a test that had an issue were also considering that issue as if they were build issues.
How to test
For the tests tab, go to this localhost example and compare with staging
(in this tree you can also see the fix of when an issue is listed because of its issue_id but without considering the issue_verion in the tests tab, which you can also compare with staging)
For the builds tab, go to this localhost example and compare with staging
Closes #728