Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/lazy load tree details #776

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat/lazy load tree details #776

merged 1 commit into from
Jan 17, 2025

Conversation

WilsonNet
Copy link
Collaborator

@WilsonNet WilsonNet commented Jan 16, 2025

Description

Lazy Load Tree Details so it uses the new split endpoints

How to test

  1. Open the Network Tab
  2. Go to Any Tree Details
  3. See if fetchs the Summary First
  4. The table for the Current Tab Second
  5. The Rest third

@WilsonNet WilsonNet force-pushed the feat/lazy-load-tree-details branch 2 times, most recently from e6efa71 to 7aa8c9e Compare January 16, 2025 21:57
@WilsonNet WilsonNet changed the base branch from main to refactor/api-response-snake-case January 16, 2025 21:57
@murilx murilx force-pushed the refactor/api-response-snake-case branch 2 times, most recently from c7fca4b to b9f33d5 Compare January 17, 2025 14:34
@WilsonNet WilsonNet force-pushed the feat/lazy-load-tree-details branch from 88fe89e to 45792cf Compare January 17, 2025 16:20
@murilx murilx force-pushed the refactor/api-response-snake-case branch from b9f33d5 to 3f7ea5e Compare January 17, 2025 16:20
@WilsonNet WilsonNet force-pushed the feat/lazy-load-tree-details branch 2 times, most recently from 86cb9ea to 3f7c564 Compare January 17, 2025 17:34
@WilsonNet WilsonNet changed the base branch from refactor/api-response-snake-case to main January 17, 2025 17:39
@WilsonNet WilsonNet force-pushed the feat/lazy-load-tree-details branch from 3f7c564 to 5b86a2f Compare January 17, 2025 18:11
@WilsonNet WilsonNet changed the title [draft]Feat/lazy load tree details feat/lazy load tree details Jan 17, 2025
@WilsonNet WilsonNet marked this pull request as ready for review January 17, 2025 18:12
Now the order of the lazy load is Summary > Current Page Tab> Other
Pages Tab
- Fixed typos in variable names (e.g., "enviroment" to "environment")
- Updated type definitions in backend and frontend files
- Refactored API calls to use a more modular approach
- Improved lazy loading of tree details in the frontend
- Updated schema.yml to reflect changes in type definitions

Closes #755
@WilsonNet WilsonNet force-pushed the feat/lazy-load-tree-details branch from 5b86a2f to 4ce802e Compare January 17, 2025 18:59
treeId,
filter = {},
enabled = true,
variant,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use full variant as default

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but it is breaking the typescript somehow

Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended. Nice job!

@WilsonNet WilsonNet merged commit 1466850 into main Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants