Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: filter by issue version #862

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

Francisco2002
Copy link
Collaborator

@Francisco2002 Francisco2002 commented Jan 30, 2025

Use issue version to filter the builds/tests data from Tree and Hardware Details. Change the issue label to issue_id v.issue_version insteand only issue_id. Example: maestro:1bad4fd734ada1f413164870f3d66961f9eccbfb v.1

Close #739

How to test

Go to any Tree or Hardware and try apply the filter by issue. Observe if the behavior is the same for the staging. See the examples below:

@Francisco2002 Francisco2002 self-assigned this Jan 30, 2025
@Francisco2002 Francisco2002 force-pushed the feat/filter-by-issue-version branch 3 times, most recently from 23ad725 to 70754e0 Compare January 31, 2025 19:05
@Francisco2002 Francisco2002 force-pushed the feat/filter-by-issue-version branch 2 times, most recently from 9503aca to 56ec831 Compare January 31, 2025 20:00
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine, there's only improvements to be made

backend/kernelCI_app/views/treeCommitsHistory.py Outdated Show resolved Hide resolved
backend/kernelCI_app/views/treeCommitsHistory.py Outdated Show resolved Hide resolved
dashboard/src/types/commonDetails.ts Outdated Show resolved Hide resolved
dashboard/src/pages/TreeDetails/TreeDetailsFilter.tsx Outdated Show resolved Hide resolved
backend/kernelCI_app/helpers/filters.py Show resolved Hide resolved
- use tuple (issue_id, issue_version) shape to pass issue filters
- create function to format issue name with version

Part of #739
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
@Francisco2002 Francisco2002 force-pushed the feat/filter-by-issue-version branch from 56ec831 to 03124be Compare February 3, 2025 18:27
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on my tests, lgtm

Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on my tests

@Francisco2002 Francisco2002 merged commit 56a49a8 into main Feb 3, 2025
5 checks passed
@Francisco2002 Francisco2002 deleted the feat/filter-by-issue-version branch February 3, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider issue version on issue filters
3 participants