-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: filter by issue version #862
Conversation
23ad725
to
70754e0
Compare
9503aca
to
56ec831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine, there's only improvements to be made
- use tuple (issue_id, issue_version) shape to pass issue filters - create function to format issue name with version Part of #739
- create a function to validate issue id and issue version for a issue - pass issue versino in functions to validate build/test (tree and hardware) - use formatter function to issue label - send the issue version in frontend Close #739
56ec831
to
03124be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on my tests, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on my tests
Use issue version to filter the builds/tests data from Tree and Hardware Details. Change the issue label to
issue_id v.issue_version
insteand onlyissue_id
. Example:maestro:1bad4fd734ada1f413164870f3d66961f9eccbfb v.1
Close #739
How to test
Go to any Tree or Hardware and try apply the filter by issue. Observe if the behavior is the same for the staging. See the examples below: