Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine node search and regression generation (alternative) #447

Merged

Conversation

r-c-n
Copy link

@r-c-n r-c-n commented Feb 28, 2024

Alternative version of #444 that doesn't depend on kernelci/kernelci-core#2378

@r-c-n r-c-n requested a review from JenySadadia February 28, 2024 07:22
@r-c-n r-c-n force-pushed the rcn-regression-tracker-fixes-provisional branch from 32d7c0c to 0582738 Compare February 29, 2024 05:27
Ricardo Cañuelo added 3 commits February 29, 2024 06:41
Restrict the search of past results to those with the same platform,
defconfig, compiler, platform, etc than the original failed test.

Update the regression generation to the latest model definitions.

Signed-off-by: Ricardo Cañuelo <[email protected]>
Until now the regression detection only worked for job submissions that
include a tree of child nodes, and the results were only checked for the
child nodes.

This fixes the detection of failed jobs that are submitted without a
hanging tree of nodes (kbuilds, kver, kunit tests). See
kernelci#337

Signed-off-by: Ricardo Cañuelo <[email protected]>
@r-c-n r-c-n force-pushed the rcn-regression-tracker-fixes-provisional branch from 0582738 to 14fd9c4 Compare February 29, 2024 05:41
Copy link
Collaborator

@JenySadadia JenySadadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. LGTM otherwise.

src/regression_tracker.py Show resolved Hide resolved
src/regression_tracker.py Show resolved Hide resolved
Copy link
Collaborator

@JenySadadia JenySadadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to verify on staging.

@r-c-n
Copy link
Author

r-c-n commented Feb 29, 2024

Tested in staging

@JenySadadia JenySadadia added this pull request to the merge queue Feb 29, 2024
Merged via the queue into kernelci:main with commit d63b144 Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants