Enable CIP lab

[JenySadadia]

Addresses kernelci/kernelci-project#361

[JenySadadia]

Hello @patersonc
I enabled CIP in the new system and tried to submit baseline job for x86.
Here is the job link: https://lava.ciplatform.org/scheduler/job/1139445
There are the same failures in the jobs submitted by legacy system as well. See https://lava.ciplatform.org/scheduler/job/1139379#bottom.
Is this the issue from the lab side or do you expect KernelCI to handle this job for CIP differently?

[patersonc]

Hello @patersonc I enabled CIP in the new system and tried to submit baseline job for x86. Here is the job link: https://lava.ciplatform.org/scheduler/job/1139445 There are the same failures in the jobs submitted by legacy system as well. See https://lava.ciplatform.org/scheduler/job/1139379#bottom. Is this the issue from the lab side or do you expect KernelCI to handle this job for CIP differently?

Hi @JenySadadia
It looks like that job is using docker.
We're using lava-docker (based on KernelCI's lava-docker) for our labs, and I'm guessing that docker-in-docker isn't supported.

[patersonc]

Ah, maybe it is supported and we need to manually enable it:
use_docker: Permit to use docker commands in slave

[patersonc]

Ah, maybe it is supported and we need to manually enable it: use_docker: Permit to use docker commands in slave

Yep, that fixed it. Here's the same job, now run in a lab with use_docker: https://lava.ciplatform.org/scheduler/job/1139581
I only have access to enable this setting in two of our five labs though - I'll need to get the other maintainers to update settings their end.

So technically this MR is working (as well as the legacy system). I'll let you decide if you want to wait for us to get dind support enabled in all of our labs before merging or not.

[JenySadadia]

Perfect, thanks.
I verified and It's working for kernelci staging submitter as well https://staging.kernelci.org:9000/viewer?node_id=6656760ca901419b4a8a597b.

I'll let you decide if you want to wait for us to get dind support enabled in all of our labs before merging or not.

I'll wait until this is fixed in all the CIP labs.

Meanwhile, what are other tests you want to enable for CIP in the new system?

[patersonc]

Hi @JenySadadia

I'll wait until this is fixed in all the CIP labs.

This should be okay now. Thanks.

Meanwhile, what are other tests you want to enable for CIP in the new system?

Is there a list to choose from somewhere?
What would be most useful to KernelCI?

[JenySadadia]

Is there a list to choose from somewhere? What would be most useful to KernelCI?

Here are the tests the legacy system runs with CIP lab:
https://github.com/kernelci/kernelci-core/blob/main/config/core/runtime-configs.yaml#L38

But not all the jobs are enabled with the new system yet. Here is the tests enabled atm:
https://github.com/kernelci/kernelci-pipeline/blob/main/config/pipeline.yaml#L193

As per the latest announcement from @padovan, we would be enabling a limited number of tests in the new system as we transit through the legacy system sunset.
So it depends on what are the important tests for CIP atm and then we can discuss further.

[padovan]

@patersonc what were the tests CIP was following the results diligently? If so, I'd suggest for you to enable those.

As a general rule, at least the collabora team, the focus is on high quality tests and engaging with the community to report high quality results, so we are not advising to enable all tests, unless you also add the engineering to support the such a high quality, high confidence process.

[patersonc]

Hello,

Looking at https://linux.kernelci.org/test/job/cip/branch/linux-5.10.y-cip/kernel/v5.10.216-cip47/, it doesn't seem like the list of tests being run matches up to the list in https://github.com/kernelci/kernelci-core/blob/main/config/core/runtime-configs.yaml#L38.

Am I missing something?

[JenySadadia]

Hello,

Looking at https://linux.kernelci.org/test/job/cip/branch/linux-5.10.y-cip/kernel/v5.10.216-cip47/, it doesn't seem like the list of tests being run matches up to the list in https://github.com/kernelci/kernelci-core/blob/main/config/core/runtime-configs.yaml#L38.

Am I missing something?

Hello,

If you click on one of the tests, it will show labs running the test. You'd see lab-cip only for the tests mentioned in the list i.e. https://github.com/kernelci/kernelci-core/blob/main/config/core/runtime-configs.yaml#L38.

[patersonc]

Ah yes, thanks Jeny.

If possible can we keep the same tests as currently run on the CIP trees? If it would help, we can run more tests in lab-cip rather than only run a subset; we have capacity.

[padovan]

@patersonc if you want to carry over all the tests that is fine. We have documentation on how to enable the tests.

[nuclearcat]

Merging, i suggest if there is follow-up work planned, to open it as issue, so it wont be blocking other PR.
Thanks!

[JenySadadia]

Hello @patersonc
Here is the documentation on enabling new kernel tree and tests in KernelCI https://docs.kernelci.org/api_pipeline/pipeline/developer-documentation/