Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wifi-basic test on the Genio 700 EVK #975

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nfraprado
Copy link
Contributor

The arm64-chromebook fragment includes several builtin firmware that are
needed for running some of the tests. Add a build job that includes it
and runs everywhere.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
This test was already defined in jobs-chromeos.yaml. In order to be able
to run it on non-chromeos platforms, add it to the main pipeline.yaml
too.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
Run the wifi-basic test on the Genio 700 EVK. The WiFi card requires
some firmware files in order to be able to boot, which are included in
the arm64-chromebook fragment, hence this job depends on the
kbuild-gcc-12-arm64-chromebook build.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
@nfraprado
Copy link
Contributor Author

There's already a kbuild-gcc-12-arm64-chromebook job in chromeos-jobs.yaml, so I've renamed the one introduced here to kbuild-gcc-12-arm64-chromebook-main to avoid the CI failures. Let me know if you want to fix the issue in a different way.

@@ -926,6 +926,15 @@ jobs:

kbuild-gcc-12-arm64: *kbuild-gcc-12-arm64-job

kbuild-gcc-12-arm64-chromebook-main:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to me to have this one a plain "-chromebook" and the other one "-chromeos" (since it's in "*-chromeos.yaml" configs).

We can merge it as it is and do the rename as a next step (here, in jobs- and scheduler- files).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds fine to me. I wanted to keep this PR contained to pipeline.yaml and so I preferred doing the name change here. But renaming the chromeos ones in a separate PR sounds good.

@@ -1895,6 +1895,19 @@ jobs:
- media
kcidb_test_suite: h26forge.debian

wifi-basic:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job definition is not anchored anywhere in the main file - did you encounter any failures in processing scheduler entries with this job definition when it's read from "jobs-chromeos.yaml"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not set up to run the kci tools here, so I'm relying on the CI checks done in github.

My understanding is that the anchors are private to the yaml file. In jobs-chromeos.yaml the only wifi-basic entry is in the anchors, so it is not visible from the pipeline.yaml, hence there are no conflicts. I think that's what you were asking, but let me know otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants