Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelci.org: make link to Foundation more meaningful #382

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

padovan
Copy link
Contributor

@padovan padovan commented Jun 10, 2024

Let's just call it Foundation as "LF" fails to share enough context to the average visitor.

Let's just call it Foundation as "LF" fails to share enough context
to the average visitor.

Signed-off-by: Gustavo Padovan <[email protected]>
@padovan padovan requested review from khilman and patersonc June 10, 2024 17:50
@padovan
Copy link
Contributor Author

padovan commented Jun 10, 2024

@patersonc @khilman please review/merge.

Copy link
Collaborator

@patersonc patersonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that "Foundation" fits in better when compared to the other menu titles.

However whether users understand what "Foundation" means I couldn't say.

Perhaps we merge this PR as-is, as I guess this link will be removed soon anyway if we're moving the "foundation" site to kernel.org, and the hugo documentation site to docs.kernel.org? Presumably this link would then become something like "Home"?

@padovan
Copy link
Contributor Author

padovan commented Jun 11, 2024

I agree that "Foundation" fits in better when compared to the other menu titles.

However whether users understand what "Foundation" means I couldn't say.

Perhaps we merge this PR as-is, as I guess this link will be removed soon anyway if we're moving the "foundation" site to kernel.org, and the hugo documentation site to docs.kernel.org? Presumably this link would then become something like "Home"?

Yes. "Home" would make more sense as we want to get people back into kernelci.org

@patersonc patersonc merged commit 67df04d into kernelci:main Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants