Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add BQ total return rows in metrics #316

Closed
wants to merge 1 commit into from

Conversation

aurelienWls
Copy link
Contributor

What changes are being made and why?

Add in the Kestra metrics the number of lines return by a BigQuery query.

This is usefull to track overtime the number of lines return by a BigQuery.Query task thanks to Kestra metrics dashboard.

This change involved loading all the data return by the query in the metrics method. This could lead to performance issue in case the query return a huge amount of data. This change has not been tested with huge query.


How the changes have been QAed?

Tested locally


Setup Instructions

@loicmathieu
Copy link
Member

There is already a total.rows metric that return the same metric value (queryJob.getQueryResults().getTotalRows() so it seems to be already covered.

This metric will not be displayed if neither store, fetch, or fetchOne is true as in this case the results are not fetched from BQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants