Make manifest title optional

keton · Jun 16, 2024 · 3805280 · 3805280
1 parent ba75d85
commit 3805280
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/backend/src/mod_loaders/mod_loader.rs b/backend/src/mod_loaders/mod_loader.rs
@@ -165,7 +165,7 @@ pub trait ModLoaderActions {
 			fs::write(
 				local_mod::get_manifest_path(&target_path),
 				serde_json::to_string_pretty(&mod_manifest::Manifest {
-					title: remote_mod.data.title.clone(),
+					title: Some(remote_mod.data.title.clone()),
 					version: latest_version.id.clone(),
 					runnable: latest_version.runnable.clone(),
 					engine: remote_mod.common.engine,

diff --git a/backend/src/mod_manifest.rs b/backend/src/mod_manifest.rs
@@ -16,7 +16,7 @@ use crate::{
 };
 
 serializable_struct!(Manifest {
-	pub title: String,
+	pub title: Option<String>,
 	pub version: String,
 	pub runnable: Option<RunnableModData>,
 	pub engine: Option<EngineBrand>,
@@ -34,7 +34,11 @@ pub fn get(path: &Path) -> Option<Manifest> {
 	{
 		Ok(manifest) => Some(manifest),
 		Err(error) => {
-			error!("Error getting manifest: {error}");
+			error!(
+				"Error getting manifest in path '{}': {}",
+				path.display(),
+				error
+			);
 			None
 		}
 	}

diff --git a/frontend/api/bindings.ts b/frontend/api/bindings.ts
@@ -141,7 +141,7 @@ export type GameEngine = { brand: EngineBrand; version: EngineVersion | null }
 export type ModDownload = { id: string; url: string; root: string | null; runnable: RunnableModData | null }
 export type OwnedGame = { id: string; provider: ProviderId; name: string; osList: OperatingSystem[]; releaseDate: BigInt | null; thumbnailUrl: string | null; gameMode: GameMode | null; providerCommands: { [key: string]: ProviderCommand } }
 export type AppEvent = "SyncInstalledGames" | "SyncOwnedGames" | "SyncRemoteGames" | "SyncModLoaders" | "SyncLocalMods" | "SyncRemoteMods" | "ExecutedProviderCommand" | "GameAdded" | "GameRemoved" | "Error"
-export type Manifest = { title: string; version: string; runnable: RunnableModData | null; engine: EngineBrand | null; engineVersionRange: EngineVersionRange | null; unityBackend: UnityScriptingBackend | null }
+export type Manifest = { title: string | null; version: string; runnable: RunnableModData | null; engine: EngineBrand | null; engineVersionRange: EngineVersionRange | null; unityBackend: UnityScriptingBackend | null }
 export type LocalMod = { data: LocalModData; common: CommonModData }
 export type InstalledGame = { id: string; name: string; provider: ProviderId; executable: GameExecutable; installedModVersions: { [key: string]: string }; discriminator: string | null; thumbnailUrl: string | null; ownedGameId: string | null; startCommand: ProviderCommand | null }
 export type RemoteGame = { id: string; engine: GameEngine | null; skipCache: boolean }