Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: form element for testing #2

Closed
wants to merge 2 commits into from
Closed

feat: form element for testing #2

wants to merge 2 commits into from

Conversation

hamirmahal
Copy link

closes #1.

@hamirmahal
Copy link
Author

Without this change

image

@hamirmahal
Copy link
Author

With this change

image

@hamirmahal hamirmahal deleted the feat/form-element-for-testing branch August 12, 2024 21:15
@hamirmahal
Copy link
Author

Any reason in particular you decided to close this?

@kevin-powell
Copy link
Owner

The virtual keyboard doesn't impact dvh. If it did, I'd keep it, but it's only the UI elements that come and go while scrolling that have an impact, so having the form doesn't have any impact on how the units work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form elements could help developers see behavior of different types of vhs
2 participants