Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/virtual joystick #63

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Conversation

jga-dev
Copy link
Contributor

@jga-dev jga-dev commented Feb 20, 2023

New feature added: Basic Virtual Joystick

Hi, I decide implement this feature because it appears to be in high demand. Hope you find interesting.

Description:

  • Joystick can be activated by button on bottom (see picture)
  • For resolutions less than 650px wide it's active by default
  • When resolution ir less than 650px and chat is active, joystick is hidden because it interferes with the chat

Captura de Pantalla 2023-02-20 a las 1 20 20

For implement this, I use this component: https://github.com/elmarti/react-joystick-component

Note: This feature will conflict with this PR: #62
I can take care of resolving conflicts

Related issues:

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for skyoffice ready!

Name Link
🔨 Latest commit ae40196
🔍 Latest deploy log https://app.netlify.com/sites/skyoffice/deploys/63f552bab2834b0008140063
😎 Deploy Preview https://deploy-preview-63--skyoffice.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

client/src/components/MobileVirtualJoystick.tsx Outdated Show resolved Hide resolved
client/src/components/Joystick.jsx Outdated Show resolved Hide resolved
client/src/components/Joystick.jsx Outdated Show resolved Hide resolved
client/src/components/Joystick.jsx Outdated Show resolved Hide resolved
client/src/components/MobileVirtualJoystick.tsx Outdated Show resolved Hide resolved
client/src/components/MobileVirtualJoystick.tsx Outdated Show resolved Hide resolved
@DaxChen
Copy link
Collaborator

DaxChen commented Feb 21, 2023

This is awesome! Thanks for your contribution, please feel free to reach out if any of the comments are unclear or if you don't agree on any of them!
BTW I did this review together with Kevin.

@jga-dev
Copy link
Contributor Author

jga-dev commented Feb 21, 2023

@DaxChen Hi, thanks for the review. I just uploaded a new commit with the changes. Anything else let me know 😊👍

@jga-dev jga-dev requested a review from DaxChen February 21, 2023 15:00
@MariaJesusGomez
Copy link

Oohh, Sounds great! As soon as this PR is resolved I'll pull the project with this feature.

Copy link
Collaborator

@DaxChen DaxChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for the fast response!

client/src/components/Joystick.tsx Outdated Show resolved Hide resolved
client/src/components/Joystick.tsx Outdated Show resolved Hide resolved
client/src/components/Joystick.tsx Outdated Show resolved Hide resolved
client/src/components/MobileVirtualJoystick.tsx Outdated Show resolved Hide resolved
@jga-dev
Copy link
Contributor Author

jga-dev commented Feb 21, 2023

@DaxChen Hi, thanks again for your review. I've applied all the changes you have commented. If you see anything else feel free to let me know.

@jga-dev jga-dev requested a review from DaxChen February 21, 2023 23:35
Copy link
Collaborator

@DaxChen DaxChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks for cleaning up the window resize listener hook part, it's way cleaner now!

@DaxChen DaxChen merged commit f93bbc7 into kevinshen56714:master Feb 22, 2023
@jga-dev jga-dev deleted the feat/virtual-joystick branch February 27, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants