-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/virtual joystick #63
Conversation
✅ Deploy Preview for skyoffice ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is awesome! Thanks for your contribution, please feel free to reach out if any of the comments are unclear or if you don't agree on any of them! |
@DaxChen Hi, thanks for the review. I just uploaded a new commit with the changes. Anything else let me know 😊👍 |
Oohh, Sounds great! As soon as this PR is resolved I'll pull the project with this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for the fast response!
@DaxChen Hi, thanks again for your review. I've applied all the changes you have commented. If you see anything else feel free to let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Thanks for cleaning up the window resize listener hook part, it's way cleaner now!
New feature added: Basic Virtual Joystick
Hi, I decide implement this feature because it appears to be in high demand. Hope you find interesting.
Description:
For implement this, I use this component: https://github.com/elmarti/react-joystick-component
Note: This feature will conflict with this PR: #62
I can take care of resolving conflicts
Related issues: