Require an input file #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zehvogel
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Unfortunately this breaks k4run --help CLDReconstruction.py
To solve this in a satisfying we would have to check if there was an input file, after arguments were parsed and before the services are instantiated and then return early. And returning early without killing k4run. Maybe we can use an exception for that?
jmcarcell
force-pushed
the
require-argument
branch
from
9b21207 to
6a52d46
Compare
|
Indeed, I'm not sure how that would be done, for now I change it to printing a warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it's not going to run without but then you'll still have to wait for DD4hep to load the geometry before failing.
BEGINRELEASENOTES
ENDRELEASENOTES