Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CLD_o2_v07 instead of CLD_o2_v06 in the sim steering file #56

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Use CLD_o2_v07 instead of CLD_o2_v06 in the sim steering file #56

merged 1 commit into from
Dec 13, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Dec 13, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Use CLD_o2_v07 instead of CLD_o2_v06 in the sim steering file. It's already being used in the reconstruction steering file, so it makes sense to use the same geometry for simulation.

ENDRELEASENOTES

Note that the documentation in https://fcc-ee-detector-full-sim.docs.cern.ch/CLD/ also has to be updated.

andresailer
andresailer approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andresailer andresailer enabled auto-merge (rebase) December 13, 2024 09:17
@jmcarcell
Copy link
Member Author

PR for the FCC documentation: https://gitlab.cern.ch/fcc-ee-detector-full-sim/docs/-/merge_requests/13

@andresailer andresailer disabled auto-merge December 13, 2024 09:26
@andresailer andresailer reopened this Dec 13, 2024
@andresailer andresailer merged commit 6cca700 into main Dec 13, 2024
9 checks passed
@andresailer andresailer deleted the use-cld-o2-v07 branch December 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @andresailer