Add a header with constants #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
reviewed
Nov 1, 2023
tmadlener
reviewed
Nov 1, 2023
include/edm4hep/Constants.h
Outdated
| #ifndef EDM4HEP_CONSTANTS_H | ||
| #define EDM4HEP_CONSTANTS_H | ||
|
|
||
| #include <string> |
There was a problem hiding this comment.
Suggested change
| #include <string> | |
| #include <string_view> |
There was a problem hiding this comment.
Actually if we make it const char* we don't need any include here.
include/edm4hep/Constants.h
Outdated
| #include <string> | ||
|
|
||
| namespace edm4hep { | ||
| inline constexpr std::string_view CellIDEncoding = "CellIDEncoding"; |
There was a problem hiding this comment.
Suggested change
| inline constexpr std::string_view CellIDEncoding = "CellIDEncoding"; | |
| inline static constexpr auto CellIDEncoding = "CellIDEncoding"; |
I think making this a static const char* makes it easier to consume for things that take a const std::string& as a string_view will lead to
error: invalid initialization of reference of type 'const std::string&' {aka 'const std::__cxx11::basic_string<char>&'} from expression of type 'const std::string_view' {aka 'const std::basic_string_view<char>'
There was a problem hiding this comment.
This will also still work if functions take a string_view as argument.
There was a problem hiding this comment.
I made it const char* (explicit in case someone checks the header); inline can be dropped since it's static
tmadlener
approved these changes
Nov 1, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for HEP-FCC/k4SimGeant4#55 and key4hep/k4EDM4hep2LcioConv#32 and other places so that we can set the same value in all places consistently.
More constants can be added if there are suggestions.
BEGINRELEASENOTES
ENDRELEASENOTES