Make test required to run successfully before deploying previews #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Is it working because the action running is actually the one which is in the main branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
test-previews.ymlthat would test only previews. If completed successfully, then previews will deploy. This will save time and resources.ENDRELEASENOTES
As proposed by @kjvbrt, these changes will improve the overall deployment process.
As usual, I've tested this on my "testing" repository. So basically, when opening a pull request, the
previewworkflow will be called. However, it then calls toTest previewswhich will checkout to the fork (PR) and test that code. Then if completed successfully, continues with normal deployment for previews. In theory, this won't run until merged, because thetest-previewsworkflow should be in the repo, but currently isn't.