Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load particles according to edm4hep #36
Load particles according to edm4hep #36
Changes from 21 commits
3cfbb4c
186024e
fbfb0ea
c7b270c
170de18
27d03ec
0a52737
02392eb
13978a4
5f48b1d
00bb203
83a9bbd
3e64c41
f7a14c5
904cd51
ba9630c
69f3fd6
a1afbfe
1715a04
cc58efa
49d5e6e
0e30a99
1ff80b6
9ba9506
57348db
c2b0742
c0c7387
8e83913
8e82181
27ba065
e82ba4c
9c0ee0a
cd53b06
aeb04e2
fc45409
bb0bc73
26597ee
0c1538b
c37b2f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing the
edm4hep::MCParticle
here (or I am missing something entirely?). It should be possible to load that through the same mechanism, right? That would also serve as a good "real world" test to see whether the scheme works to get to a useful representation in memory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I have missed this bit before when I was talking about dropping the types. Do we need the type information for members that are components? (I.e. the things starting with
edm4hep::
? If yes, than we might as well just keep all the type information instead of selectively dropping stuff. If we don't need the type information for the components either, I think we can drop all of them here.Checking whether we can fit the
MCParticle
into this dynamic scheme should give as a good indication of what is needed, I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought to keep only types from objects that contain
edm4hep::
because maybe when drawing relations, we may need to know towards what type of object the relation is. But you are right; currently it isn't necessary, and we may continue without them. Also, I've includedMCParticle
which loads seamlessly. Using the testing json file, I get thiswhen running the loading function, without error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this also already used when I load a file in the viewer for displaying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, not.