Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load particles according to edm4hep #36
Load particles according to edm4hep #36
Changes from 20 commits
3cfbb4c
186024e
fbfb0ea
c7b270c
170de18
27d03ec
0a52737
02392eb
13978a4
5f48b1d
00bb203
83a9bbd
3e64c41
f7a14c5
904cd51
ba9630c
69f3fd6
a1afbfe
1715a04
cc58efa
49d5e6e
0e30a99
1ff80b6
9ba9506
57348db
c2b0742
c0c7387
8e83913
8e82181
27ba065
e82ba4c
9c0ee0a
cd53b06
aeb04e2
fc45409
bb0bc73
26597ee
0c1538b
c37b2f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit poorly named. In the end not everything in the datamodel will be something that resembles a particle. Maybe
EDMObject
or something like that would be a better name here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether it's necessary to differentiate between
Particle
andReconstruction
in this case. In the end we want all of the datatypes that we find in the yaml file to be on sort of the same level (at least for reading in). We can then still group them in some other way, but we will probably do that manually. Additionally, since the bodies for all of these are effectively the same, I think they could also go into the file that is generated, since we will do it for (almost) all datatypes in any case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I'm going to create only a general
EDMObject
(as you mentioned) that will probably contain common features across all the objects. Also, I don't think it's necessary to add it to the generated file, because thisEDMObject
should contain more "logic" than relevant information when loading.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really apply for all of the occurences?
vertex
in itself doesn't have a unit, the position of a vertex on the other hand probably will, so maybeposition
would be better here thanvertex
?