Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate objects when drawing #77

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

brauliorivas
Copy link
Member

BEGINRELEASENOTES

  • There is a problem in Object stays drawn, and copy can be moved #74, where an object was drawn twice in the Reco-Cluster-Track-Vertex view. The root cause was the pre-filtering functions for each view. These functions were assuming some "cardinality" for relations. What I mean is that one reco particle may have many clusters, and assumed that one cluster belongs to only one reco, which was wrong.
  • To fix this, I've used some sets to ensure no object is added twice. This bug was present not only in that view but also in those views that are relations (that recently changed the name to link, like MCRecoLink). So I've also added validations for those views.

ENDRELEASENOTES

@brauliorivas brauliorivas linked an issue Aug 10, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 10, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-12 14:58 UTC

@kjvbrt
Copy link
Collaborator

kjvbrt commented Aug 12, 2024

Excellent fix :)

@kjvbrt kjvbrt merged commit 57d2787 into key4hep:main Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object stays drawn, and copy can be moved
2 participants