WIP: Move CLUE algo in external library #17
Conversation
|
It would be awesome if @fdplacido and @vvolkl can have a look, given their experience in cmake and external libraries. In particular it is not clear to me how to treat now the |
| set_property(TARGET CLUE APPEND PROPERTY IMPORTED_CONFIGURATIONS NOCONFIG) | ||
| set_target_properties(CLUE PROPERTIES | ||
| IMPORTED_LINK_INTERFACE_LANGUAGES_NOCONFIG "CXX" | ||
| IMPORTED_LOCATION_NOCONFIG "${_IMPORT_PREFIX}/lib64/libCLUE.a" |
There was a problem hiding this comment.
this lib needs to be compiled first, and linked by using target_link_libraries
| @@ -0,0 +1,4 @@ | |||
| ## -*- ascii -*- | |||
There was a problem hiding this comment.
Remove config generated files
There was a problem hiding this comment.
The current PR won't compile.
The general approach would be to compile clueLib as a library target using add_library as you are doing, compile the k4Clue (the wrapper) as the executable, and then target_link_library clueLib to k4Clue.
If in the future the lib lives in a different repo we would need to deal with it as a submodule (or using FetchContent which I would favor), and compiler in a similar way.
For the clueLib folder I would remove the lib, lib64, python and share folders.
For the source_group I don't think you need it, and I would also favor including all the files explicitly, or doing include_directories.
This would be:
- Remove generated stuff in clueLib
- Create a CMakeLists.txt for clueLib that compiles it as a lib, and call
add_subdirectoryfor clueLib first - In k4Clue link to the clueLib
- Consider for the future if using git submodule or FetchContent
|
Thanks for the feedback. I am going to close this PR and create a new one. |
BEGINRELEASENOTES
ENDRELEASENOTES