Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Merge the PodioDataSvc into k4DataSvc #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Nov 17, 2023

BEGINRELEASENOTES

  • Merge the internal PodioDataSvc into the visible k4DataSvc and make that part of the core library instead of the plugins. Fixes Merge k4DataSvc and PodioDataSvc #104
  • Remove the FCCDataSvc.

ENDRELEASENOTES

@tmadlener tmadlener force-pushed the rm-podiodatasvc branch 3 times, most recently from a350795 to 597ad72 Compare May 23, 2024 14:46
- Move k4DataSvc to core library
- Make PodioDataSvc an alias for now
@tmadlener
Copy link
Contributor Author

Brought this back to live via some cherry-picking and some merge resolutions. Things are not yet completely working yet, but it should be easier to fix the remaining issues now. One of the open things is the following warning:

https://github.com/key4hep/k4FWCore/actions/runs/9210346272/job/25337137482?pr=163#step:3:275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge k4DataSvc and PodioDataSvc
1 participant