Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Lcio2EDM4hepTool a friend of PodioDataSvc #194

Merged
merged 1 commit into from
May 17, 2024
Merged

Make the Lcio2EDM4hepTool a friend of PodioDataSvc #194

merged 1 commit into from
May 17, 2024

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented May 10, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Make the Lcio2EDM4hepTool a friend of PodioDataSvc to enable event parameter conversion

ENDRELEASENOTES

See discussion in: key4hep/k4MarlinWrapper#184

@Zehvogel Zehvogel mentioned this pull request May 10, 2024
Merged
1 task
@Zehvogel Zehvogel changed the title Return non-const event frame for MarlinWrapper Make the Lcio2EDM4hepTool a friend of PodioDataSvc May 13, 2024
@Zehvogel Zehvogel requested review from andresailer and tmadlener May 17, 2024 07:26
@andresailer andresailer self-requested a review May 17, 2024 07:49
@andresailer andresailer merged commit 0c3aebf into key4hep:main May 17, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-fila m-fila m-fila left review comments

@andresailer andresailer andresailer approved these changes

@tmadlener tmadlener Awaiting requested review from tmadlener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zehvogel @andresailer @tmadlener @m-fila