-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on I/O #267
Conversation
doc/PodioInputOutput.md
Outdated
|
||
evtSvc = k4DataSvc("EventDataSvc") | ||
io_svc = IOSvc("IOSvc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we need / want to mention this explicitly in the documentation but I think "IOSvc"
is pretty much required as name for the IOSvc
, right? At least some of the CLI examples below will only work with that. Can we create an empty IOSvc()
and rely on a default name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mention:
The service should be imported from
k4FWCore
and named "IOSvc" as other components may look for it under this name.
Yes, naming it differently might be a problem. Relaying on the default name works fine.
Added a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked to make sure and I didn't see any errors when using a different name or no name at all for IOSvc
. Only the Reader
and Writer
retrieve it through a ServiceHandle
.
I don't have any more comments. Anything else @m-fila? |
I noticed that Otherwise that's all. Thank you very much for the comments 😄 |
I had the same thought when I was reading the diffs. I'm not sure, in this case this was literally the same command as it is used with |
…vice coupled with legacy io Co-authored-by: jmcarcell <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
5c2290c
to
b59f46d
Compare
BEGINRELEASENOTES
IOSvc
k4DataSvc
to legacy pageENDRELEASENOTES
Some extensions (namely
sphinx-design
and from myst_parsercolon_fence
) are used to render the pages more nicely in sphinx-based documentation with admonitions and tabs (setting properties either in steering file or from command line):Closes #212