Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer necessary specification of input collections #171

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Cleanup the clic reconstruction from EDM4hep inputs example a bit.
    • Remove commented LCIO input
    • Remove explicit listing of input collections, which is no longer necessary after k4FWCore#162

ENDRELEASENOTES

Copy link
Member

@jmcarcell jmcarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tomorrow the CI should pass

@tmadlener
Copy link
Contributor Author

Ah, I just realize that this has not yet made it into the release yet. Since it is effectively mainly a documentation change I have no strong opinion on whether we should merge it now or later.

@tmadlener
Copy link
Contributor Author

Release based workflows are now failing because the input files are no longer compatible.

@tmadlener tmadlener merged commit d217a4a into key4hep:main Mar 14, 2024
6 of 10 checks passed
@tmadlener tmadlener deleted the cleanup-example branch March 14, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants