fix type instabilities (#59)

* change global variable mockup alg default time a constant * make BoundAlgorithm a parametric type * fix type instability in DataFlowGraph
key4hep · Oct 29, 2024 · 241b353 · 241b353
1 parent 3ad7183
commit 241b353
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/mockup.jl b/src/mockup.jl
@@ -18,7 +18,7 @@ struct MockupAlgorithm <: AbstractAlgorithm
     end
 end
 
-mockup_alg_default_runtime_s::Float64 = 0
+const mockup_alg_default_runtime_s = 0
 
 function (alg::MockupAlgorithm)(args...; event_number::Int,
                                 coefficients::Union{Vector{Float64}, Missing})

diff --git a/src/scheduling.jl b/src/scheduling.jl
@@ -13,8 +13,8 @@ function get_name(alg::AbstractAlgorithm)
     error("Subtypes of AbstractAlgorithm must implement get_name")
 end
 
-struct BoundAlgorithm
-    alg::AbstractAlgorithm
+struct BoundAlgorithm{T <: AbstractAlgorithm}
+    alg::T
     event_number::Int
 end
 
@@ -28,7 +28,7 @@ function get_name(alg::BoundAlgorithm)
 end
 
 struct DataFlowGraph
-    graph::MetaDiGraph
+    graph::MetaDiGraph{Int, Float64}
     algorithm_indices::Vector{Int}
     function DataFlowGraph(graph::MetaDiGraph)
         alg_vertices = MetaGraphs.filter_vertices(graph, :type, "Algorithm")