fix missing ! for schedule_graph

key4hep · Aug 26, 2024 · b4eb5ac · b4eb5ac
1 parent fd73510
commit b4eb5ac
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/scheduling.jl b/src/scheduling.jl
@@ -96,7 +96,7 @@ function schedule_algorithm(event::Event, vertex_id::Int,
     end
 end
 
-function schedule_graph(event::Event, coefficients::Union{Dagger.Shard, Nothing})
+function schedule_graph!(event::Event, coefficients::Union{Dagger.Shard, Nothing})
     terminating_results = Dagger.DTask[]
     for vertex_id in event.data_flow.algorithm_indices
         res = schedule_algorithm(event, vertex_id, coefficients)
@@ -131,7 +131,7 @@ function run_pipeline(graph::MetaDiGraph;
             @info dispatch_end_msg(finished_graph_id)
         end
         event = Event(data_flow, idx)
-        terminating_tasks = FrameworkDemo.schedule_graph(event, coefficients)
+        terminating_tasks = FrameworkDemo.schedule_graph!(event, coefficients)
         graphs_tasks[idx] = Dagger.@spawn notify_graph_finalization(notifications, idx,
                                                                     terminating_tasks...)
 

diff --git a/test/demo_workflows.jl b/test/demo_workflows.jl
@@ -9,7 +9,7 @@ function run_demo(name::String, coefficients::Union{Dagger.Shard, Nothing})
         graph = FrameworkDemo.parse_graphml(path)
         df = FrameworkDemo.DataFlowGraph(graph)
         event = FrameworkDemo.Event(df)
-        @test_nowarn wait.(FrameworkDemo.schedule_graph(event, coefficients))
+        @test_nowarn wait.(FrameworkDemo.schedule_graph!(event, coefficients))
     end
 end
 

diff --git a/test/scheduling.jl b/test/scheduling.jl
@@ -51,7 +51,7 @@ end
     Dagger.enable_logging!(tasknames = true, taskdeps = true)
     _ = Dagger.fetch_logs!() # flush logs
 
-    tasks = FrameworkDemo.schedule_graph(event, coefficients)
+    tasks = FrameworkDemo.schedule_graph!(event, coefficients)
     wait.(tasks)
 
     logs = Dagger.fetch_logs!()