CPU crunching for more realistic algorithm #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function to find the nth prime number with helpers for worker calibration
Calibration coefficient is stored on each worker and used to crunch for average runtime using prime number finder
m-fila
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Looks good 👍
I'm not sure if linear calibration with a single coefficient is always a good approximation since the density of primes is not constant. Maybe we could check how does the time vs number of iterations looks like and maybe replace single coefficient with a list and do some linear or polynomial approximation. We'd need to know a typical range of algorithm execution times - we could calculate it from ATLAS example. This'd require some more work, so I'd rather stay here with basic mechanism and if needed revise in another PR
It uses an more naive approach that is not dependent on the density of primes
Calibration now involves two parameters instead of one
m-fila
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
examples/schedule.jl)ENDRELEASENOTES