Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for cpu crunching #30

Merged
merged 14 commits into from
Aug 7, 2024
Merged

Add benchmarks for cpu crunching #30

merged 14 commits into from
Aug 7, 2024

Conversation

m-fila
Copy link
Collaborator

@m-fila m-fila commented Aug 6, 2024

BEGINRELEASENOTES

  • Added benchmark infrastructure
  • Added benchmarks for cpu crunching calibration

ENDRELEASENOTES

Added some basic benchmarks to check CPU crunching calibration on local worker

Benchmark add to the main Project.toml instead of creating another one in subdirectory because the main package is not registered and uses git-submodules which doesn't play very nice with julia packages

It would be good to add option for filtering which benchmarks to run as they can get quite some time. I tried indexing BenchmarkGroup with @tagged but failed somehow


Example plots (AMD Ryzen 7 5700G @ 3.800GHz )
bench_crunch_for_seconds
bench_find_primes

@m-fila m-fila requested a review from joott August 6, 2024 07:46
Copy link
Collaborator

@joott joott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a tiny change for the readme.

benchmark/README.md Outdated Show resolved Hide resolved
@m-fila m-fila merged commit d3151ec into key4hep:main Aug 7, 2024
2 checks passed
@m-fila m-fila deleted the bench branch August 7, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants