Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix event storage for concurrent execution #43

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

m-fila
Copy link
Collaborator

@m-fila m-fila commented Aug 26, 2024

BEGINRELEASENOTES

  • Added Event and Dataflow structs
  • Fixed event storage for concurrent execution

ENDRELEASENOTES

The pipeline running function introduced in #29 was reusing the parsed graph (graph topology and description) instead of creating a new instance for each event. It went unnoticed that the schedule_graph methods mutates the graph by using it for storing algorithms` futures.

As a fix two new structs are introduces:

  • DataFlowGraph to held immutable information about graph topology and algorithms, and possibly do some graph topology caching
  • Event holding mutable event specific storage and access to immutable DataFlowGraph
  • schedule_graph is renamed to schedule_graph! to indicate it mutates Event

@m-fila m-fila merged commit fe2e86a into key4hep:main Aug 27, 2024
3 checks passed
@m-fila m-fila deleted the concurrent branch August 27, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant