Clean-up specifing dependencies to unregistered packages with [sources]
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
[sources]to specify dependencies to unregistered packages. Removed the git submodule as[sources]are preferredENDRELEASENOTES
In julia 1.11 a new section
[sources]was added that allows to describe dependencies to local packages or unregistered packages.So far the main project had deps on some benchmarking packages to allow running benchmark scripts. Now a separate enviroment for the benchmarks can be created and benchmark packages are moved there
The
GraphMLReaderis an unregistered package we use for parsing. Previously it was added in a very dirty way with submodule. Now this can be done with[sources]The sources has one caveat: the unregistered packages don't propagate an information for their version so downstream packages also have to specify them. Aqua complains about it in persistent_task (it's actually because Aqua thinks this can hinder the package pre-compilation but it's a false-positive as pre-compilation works fine)