Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for CLDConfig #594

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Add a recipe for CLDConfig #594

merged 8 commits into from
Jun 6, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 5, 2024

@Zehvogel
Installation is done here https://github.com/key4hep/CLDConfig/blob/e03be6e2caa7af1860844ee6fdc811e8449326dd/CMakeLists.txt#L28. If all looks good I think this should be ready.

@Zehvogel
Copy link
Contributor

Zehvogel commented Jun 5, 2024

I think we need some more dependencies, at the moment this should not even be enough to parse the steering file

  • k4MarlinWrapper
  • MarlinTrkProcessors
  • ConformalTracking
  • DDMarlinPandora
  • CLICPerformance
  • LCFIPlus (but not used by default after Refactor II CLDConfig#30)
  • MarlinFastJet

@Zehvogel
Copy link
Contributor

Zehvogel commented Jun 5, 2024

can we also get a CLDConfig environment variable pointing to the install dir? :)

@jmcarcell
Copy link
Member Author

jmcarcell commented Jun 5, 2024

Done. I think for consistency it should be CLDCONFIG, we only have lower case for some like k4geo_DIR but we use upper case for almost all of them.

@Zehvogel
Copy link
Contributor

Zehvogel commented Jun 5, 2024

still missing MarlinFastJet

otherwise LGTM

@jmcarcell jmcarcell merged commit 354e3ce into main Jun 6, 2024
5 checks passed
@jmcarcell jmcarcell deleted the cldconfig branch June 6, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants