Update remark-gfm and remove remark-emoji to deal with compat issues …

…in the newer react-markdown Fixed #1326
keyboardio · Mar 4, 2024 · 9b8461f · 9b8461f
1 parent 2dc9ca6
commit 9b8461f
Show file tree

Hide file tree

Showing 3 changed files with 194 additions and 493 deletions.
diff --git a/package.json b/package.json
@@ -98,8 +98,7 @@
     "react-draggable": "^4.4.6",
     "react-i18next": "^11.8.5",
     "react-markdown": "^9.0.1",
-    "remark-emoji": "3.0.1",
-    "remark-gfm": "^3.0.1",
+    "remark-gfm": "^4.0.0",
     "typeface-roboto": "^0.0.54",
     "typeface-source-code-pro": "^0.0.71",
     "uuid": "^8.3.1"

diff --git a/src/renderer/screens/FirmwareUpdate/FirmwareChangesDialog.js b/src/renderer/screens/FirmwareUpdate/FirmwareChangesDialog.js
@@ -25,7 +25,6 @@ import DialogTitle from "@mui/material/DialogTitle";
 import React from "react";
 import { useTranslation } from "react-i18next";
 import ReactMarkdown from "react-markdown";
-import remarkEmoji from "remark-emoji";
 import remarkGfm from "remark-gfm";
 
 const FirmwareChangesDialog = (props) => {
@@ -42,7 +41,7 @@ const FirmwareChangesDialog = (props) => {
         </Button>
       </DialogTitle>
       <DialogContent dividers>
-        <ReactMarkdown remarkPlugins={[remarkGfm, remarkEmoji]}>{props.changelog}</ReactMarkdown>
+        <ReactMarkdown remarkPlugins={[remarkGfm]}>{props.changelog}</ReactMarkdown>
       </DialogContent>
       <DialogActions>
         <Button onClick={props.onClose}>{t("dialog.close")}</Button>