This repository has been archived by the owner on Jul 13, 2021. It is now read-only.
Send numlock keypress when disabling the numpad layer. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the OS being stuck with Numlock on, which leaves the LED on if other keyboard are attached, and breaks FVWM. See keyboardio/Model01-Firmware#42
|
Just tested this along with #3, both work as advertised, and I couldn't spot any regressions, so I'll merge both. Thank you for figuring out how to improve the situation, and submitting these PRs! |
|
I will have to check, but I am pretty sure that these do conflict.... |
|
Yep, just like I thought, it breaks the intended behavior of #3 The test procedure:
Working on a patch. |
MartyGentillon
added a commit
to MartyGentillon/Kaleidoscope-NumPad
that referenced
this pull request
Mar 15, 2018
Test procedure: 1. Make sure numlock is off on host machine. 2. Activate num layer. Confirm, numlock is now on. 3. Deactivate num layer. Confirm, numlock is now off. 4. Using another keyboard, activate numlock on host machine. 5. Activate num layer. Confirm, numlock is still on. 6. Deactivate num layer. Confirm, numlock is still on. Prior to this commit, step 6 resulted in numlock being off. see keyboardio#2 see keyboardio#3 see keyboardio#1 see keyboardio#6
MartyGentillon
added a commit
to MartyGentillon/Kaleidoscope-NumPad
that referenced
this pull request
Mar 15, 2018
Test procedure: 1. Make sure numlock is off on host machine. 2. Activate num layer. Confirm, numlock is now on. 3. Deactivate num layer. Confirm, numlock is now off. 4. Using another keyboard, activate numlock on host machine. 5. Activate num layer. Confirm, numlock is still on. 6. Deactivate num layer. Confirm, numlock is still on. Prior to this commit, step 6 resulted in numlock being off. see keyboardio#2 breaks keyboardio#3 see keyboardio#1 fixes keyboardio#6
MartyGentillon
added a commit
to MartyGentillon/Kaleidoscope-NumPad
that referenced
this pull request
Mar 15, 2018
Test procedure: 1. Make sure numlock is off on host machine. 2. Activate num layer. Confirm, numlock is now on. 3. Deactivate num layer. Confirm, numlock is now off. 4. Using another keyboard, activate numlock on host machine. 5. Activate num layer. Confirm, numlock is still on. 6. Deactivate num layer. Confirm, numlock is still on. Prior to this commit, step 6 resulted in numlock being off. see keyboardio#2 broken keyboardio#3 see keyboardio#1 fixes keyboardio#6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the OS being stuck with Numlock on, which leaves the LED on
if other keyboard are attached, and breaks FVWM.
See keyboardio/Model01-Firmware#42