Update how we do our simulator builds to try to avoid a race when building the arduino core #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mulator This makes it easier to smoke test more stuff in the simulator
This will be run before any other tests when running simulator tests. In theory, this might help prevent race conditions during simulator testing in CI from causing test failures
… the plugins directory) Update the "tests failed" output to be a little bit more friendly
case-sensitive filesystems. (This is an older plugin not used in current code)
tlyu
reviewed
Dec 14, 2023
| @@ -15,7 +15,7 @@ | |||
| * this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| #include "Kaleidoscope/plugin/LEDEffect-BootAnimation.h" | |||
| #include "Kaleidoscope-LEDEffect-BootAnimation.h" | |||
There was a problem hiding this comment.
nit: I would fix the capitalization error, instead of using the Kaleidoscope- version, for consistency with other plugins.
There was a problem hiding this comment.
Oops. I'd thought I was going with house style. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls forward a sketch + libraries build that ought to warm our caches and prevent clobbering