Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the LEDControl plugin #1405

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

EvyBongers
Copy link
Contributor

No description provided.

plugins/Kaleidoscope-LEDControl/README.md Show resolved Hide resolved
plugins/Kaleidoscope-LEDControl/README.md Show resolved Hide resolved

> See [[event-handler-hooks]]

### `.setup(void)`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to explain this one. I half expect it to be documented elsewhere and that I should refer to that, but I failed to find it.

> Triggers the currently active LED mode to refresh the LED at the specified key
> address.

### `.activate(LEDModeInterface *plugin)`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to write something along the lines of "Activates the specified LED mode." However, that would not prevent the judgement error recently pointed out to me that this actually invokes and depends on PROGMEM and/or EEPROM.

@obra
Copy link
Member

obra commented Mar 12, 2024

Thank you so much for working on this. I do so wish that we had a decent way for method-level docs to live next to the methods they're documenting and to generate pretty looking readable docs.

@EvyBongers
Copy link
Contributor Author

Doxygen can't do that?

https://www.doxygen.nl/manual/docblocks.html

@obra
Copy link
Member

obra commented Mar 12, 2024 via email

@EvyBongers EvyBongers marked this pull request as ready for review March 13, 2024 21:03

> Returns the current LED mode.

### `.get_mode<typename>()`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to properly explain this. Having looked at the commit you mentioned on discord I understand what it does, but I don't know the words to explain it.

@EvyBongers
Copy link
Contributor Author

This is the best I can do at this time

@obra obra merged commit 18b588b into keyboardio:master Mar 13, 2024
8 checks passed
@obra
Copy link
Member

obra commented Mar 13, 2024

This is great. Thanks!

@EvyBongers EvyBongers deleted the docs/LEDControl branch March 21, 2024 20:23
EvyBongers added a commit to EvyBongers/Kaleidoscope that referenced this pull request May 7, 2024
* Get started with LEDControl documentation
* Add documentation for a number of methods

Signed-off-by: Evy Bongers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants