refactor KeyboardioHID more abstractly #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the field names for the HID descriptor. This was only filled using a macro, so no change in the resulting bytes. Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
It contains the "portable" constants that a front-end API might use. Convert AbsoluteMouseAPI to depend on this, without needing HID.h. Signed-off-by: Taylor Yu <[email protected]>
This makes it easier to get the simulator tests working again. Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Slight behavior change, but it's not a problem if we report a smaller endpoint size to the host than we've allocated for endpoint buffer RAM. Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
There are no remaining lines from the Arduino original. Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
Signed-off-by: Taylor Yu <[email protected]>
|
Cool. Thanks. Does this feel ready to merge to you? |
|
I think so. It's been stable for quite some time. There is one behavior change that I did to work around what seems like a bug in clang-format-15 that's not present in my local version. I think it was trying to align assignments that it shouldn't have, maybe across different blocks, or even different functions? Hopefully the commit message makes it somewhat clear. |
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the platform-independent front end bits out out of KeyboardioHID, so they can be used by other back ends that aren't based on PluggableUSB.