Expand palette to 24 colors

[EvyBongers]

Following up on #1416, this PR updates the led palette to support 24 colors

[EvyBongers]

So far it's just the bare minimum to support 24 colors. We should probably use a variable to define the palette size and and update the macro to accept a list of arguments rather than hard coding a fixed number of arguments.

[obra]

Indeed, that little bit of refactoring is probably worth doing. And hm. Is the macro change going to break existing sketches?

…

On Fri, Apr 19, 2024 at 1:11 PM Evy Bongers ***@***.***> wrote: So far it's just the bare minimum to support 24 colors. We should probably use a variable to define the palette size and and update the macro to accept a list of arguments rather than hard coding a fixed number of arguments. — Reply to this email directly, view it on GitHub <#1418 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALC2BF3ST657TYVHJK6N3Y6F27TAVCNFSM6AAAAABGPYKPJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGIZDAMZUGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[EvyBongers]

The way it is structured now, probably. I'm thinking that there should be a way to refactor it that supports any number of colors (like how qukeys are handled). That should supply a default to black (off) in case the sketch supplies less colors that the palette supports.

[obra]

Sorry for my radio silence. I think the only thing left on this PR is the macro change not breaking existing sketches - https://github.com/keyboardio/Kaleidoscope/actions/runs/8772302322/job/24071073901?pr=1418#step:5:996

[obra]

Looks like tests are still a little sad:

https://github.com/keyboardio/Kaleidoscope/actions/runs/8929088241/job/24526089322#step:5:1009

[EvyBongers]

I noticed. The weird thing is that the M100 sketch I have locally (that uses the same macro) does build just fine. I just haven't included that because it includes most (if not all) the other changes that we discussed in the redesign issue. I have yet to figure out what the relevant difference is.

[obra]

It may be an issue with the older GCC used for AVR Arduino.

[EvyBongers]

It may be an issue with the older GCC used for AVR Arduino.

That will be the issue.

The extra comma in printf("hello",) is a syntax error in C and C++. C++20 solved this problem by adding a new special identifier, VA_OPT. The sequence VA_OPT(x), which is only legal in the substitution list of a variable-argument macro, expands to x if VA_ARGS is non-empty and to nothing if it is empty.

(https://www.scs.stanford.edu/~dm/blog/va-opt.html#variable-argument-macros)

[EvyBongers]

I found a way to get the build passing. I have yet to verify if the code functions as expected, which is why I converted it back to draft