This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
WIP remove GD32 recvControl workaround
#92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlyu
force-pushed
the
wip-recvcontrol
branch
3 times, most recently
from
0713c9c to
f5bc8e7
Compare
Use singletons for the HID objects, so Kaleidoscope can force an ordering for the interfaces, because some BIOSes/UEFIs require that the boot keyboard be the first HID interface. Signed-off-by: Taylor Yu <[email protected]>
Remove the GD32 `recvControl` workaround, because changes to the USB core mean that it's no longer required, and the automatic buffer will cause stack corruption due to being written to after `recvControl` returns.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the GD32
recvControlworkaround, because changes to the USB core mean that it's no longer required, and the automatic buffer will cause stack corruption due to being written to afterrecvControlreturns.This needs to be coordinated with keyboardio/ArduinoCore-GD32-Keyboardio#18.