handle repeated START condition correctly #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Atmel TWI interface can indicate an "unexpected STOP" when there's a repeated START condition. Don't try to treat it as a bus error, and don't wait for TWSTO to clear even if we do have a bus error (and it's not officially documented that reading TWSTO is meaningful). Previously, a repeated START condition would cause the receiver to loop waiting for TWSTO to clear. This meant it would miss an address match in a repeated START condition, resulting in a default NAK until the next START condition (which might clear TWSTO?). Signed-off-by: Taylor Yu <[email protected]>
|
@tlyu: assuming you'd like |
You are welcome to cherry-pick it for your repo if you like. (I think that will preserve author attribution unless you override some stuff in git.) I prefer not to make pull requests if I don't have a way to test the code. Note that there is also a related #20 that might make additional improvements in some situations. |
|
Done and done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17.
The Atmel TWI interface can indicate an "unexpected STOP" when
there's a repeated START condition. Don't try to treat it as a bus
error, and don't wait for TWSTO to clear even if we do have a bus
error (and it's not officially documented that reading TWSTO is
meaningful).
Previously, a repeated START condition would cause the receiver
to loop waiting for TWSTO to clear. This meant it would miss
an address match in a repeated START condition, resulting in a
default NAK until the next START condition (which might clear
TWSTO?).
Signed-off-by: Taylor Yu [email protected]