Incorrectly resolved {project_versionNpm} expression in the documenta… #563
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
closes #562
PR adds the expression
version_nodejs_adapter
to theguides.adoc
, which is replaced duringnpm run guides
with the current version of the adapter . This property is consumed in thenodejs-adapter.adoc
.Testing
I wanted to test the documentation rendered correctly in keycloak-web . So did this:
Executed the
Release
andRelease nightly
workflow in my node.js fork. I've updated the organization ( Fake commit to do this mposolda@d0f07bf ) and did thenightly
release and the fake 25.1.5 release:Run keycloak-web build with slightly modified PR Consume keycloak-nodejs-connect guides keycloak-web#551 to make sure that it can download from my ghorganization
mposolda
instead of main organizationkeycloak
.Checked the rendered guides by keycloak-web (both released guide and nightly guide) has correctly replaced version in the nodejs file like for example: