docs: Add getOrientation, getWindowDensity, and getWindowSize APIs #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
approved these changes
May 17, 2024
| Returns the window size (native resolution) of the display as (int x, int y). | ||
|
|
||
| ## Description | ||
| Use this method to get the size of the entire display. It may or may not include [system decoration areas](https://developer.android.com/reference/android/view/Display) |
There was a problem hiding this comment.
Can we explain when it does or doesn't?
There was a problem hiding this comment.
Good question. I'll have to investigate if I need to iterate keymanapp/keyman#11436 and use the following for API 30+
https://developer.android.com/reference/android/view/WindowMetrics#getBounds()
Co-authored-by: Marc Durdin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1268 and documents Keyman Engine for Android 18.0 API's added from keymanapp/keyman#11436
TODO. Document some more API's from previous releases