Merge pull request #12791 from keymanapp/fix/android/disable-auto-cor…

…rect chore(android): Disable auto-correct UI controls
keymanapp · Dec 6, 2024 · 30ed4b8 · 30ed4b8
2 parents a420e7c + fe7ab9b
commit 30ed4b8
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/LanguageSettingsActivity.java b/android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/LanguageSettingsActivity.java
@@ -108,11 +108,11 @@ public void onCreate(Bundle savedInstanceState) {
     RadioGroup radioGroup = (RadioGroup) findViewById(R.id.suggestion_radio_group);
     radioGroup.clearCheck();
 
+    // Auto-correct disabled for Keyman 18.0 #12767
     int[] RadioButtonArray = {
       R.id.suggestion_radio_0,
       R.id.suggestion_radio_1,
-      R.id.suggestion_radio_2,
-      R.id.suggestion_radio_3};
+      R.id.suggestion_radio_2};
     RadioButton radioButton = (RadioButton)radioGroup.findViewById(RadioButtonArray[maySuggest]);
     radioButton.setChecked(true);
 

diff --git a/android/KMEA/app/src/main/res/layout/language_settings_list_layout.xml b/android/KMEA/app/src/main/res/layout/language_settings_list_layout.xml
@@ -90,12 +90,13 @@
                 android:layout_gravity="center_vertical"
                 android:text="@string/suggestions_radio_2" />
 
-            <com.google.android.material.radiobutton.MaterialRadioButton
+            <!-- Auto-correct disabled for Keyman 18.0 #12767 -->
+            <!--com.google.android.material.radiobutton.MaterialRadioButton
                 android:id="@+id/suggestion_radio_3"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_gravity="center_vertical"
-                android:text="@string/suggestions_radio_3" />
+                android:text="@string/suggestions_radio_3" /-->
 
         </RadioGroup>
 

diff --git a/android/docs/help/android_images/disable-suggestions.png b/android/docs/help/android_images/disable-suggestions.png
diff --git a/android/docs/help/basic/using-the-banner.md b/android/docs/help/basic/using-the-banner.md
@@ -10,6 +10,18 @@ Keyman keyboards now always display a banner above the keyboard for one of the f
 * Display a Keyman-themed banner so popups and gestures for the top row of keys are visible
 * Reserved for future functionality
 
+## Controlling the Keyboard Banner Mode
+
+The banner mode can be controlled by going to Keyman Settings --> (select an installed language)
+
+At the bottom of the language settings menu are three controls for the banner:
+
+![](../android_images/disable-suggestions.png)
+
+* Disable suggestions (Display image banner instead)
+* Predictions only (Suggestion banner displays predictions)
+* Predictions with corrections (Suggestion banner displays predictions and corrections)
+
 ## Using the Suggestion Banner
 
 If a [dictionary is installed](installing-dictionaries) and enabled for the active Keyman keyboard, the banner will display suggestions that can be selected.