chore: address review comments

keymanapp · Dec 4, 2024 · 5ec2ce7 · 5ec2ce7
1 parent 4c3b213
commit 5ec2ce7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/core/docs/api/changes.md b/core/docs/api/changes.md
@@ -43,7 +43,7 @@ title: Changes - Keyman Core API
 [km_core_keyboard_attrs]: keyboards#km_core_keyboard_attrs "km_core_keyboard_attrs struct"
 [km_core_keyboard_key]: keyboards#km_core_keyboard_key "km_core_keyboard_key struct"
 [km_core_keyboard_imx]: keyboards#km_core_keyboard_imx "km_core_keyboard_imx struct"
-[km_core_keyboard_load]: keyboards#km_core_keyboard_load "km_core_keyboard_load function"
+[km_core_keyboard_load_from_blob]: keyboards#km_core_keyboard_load_from_blob "km_core_keyboard_load_from_blob function"
 [km_core_keyboard_dispose]: keyboards#km_core_keyboard_dispose "km_core_keyboard_dispose function"
 [km_core_keyboard_get_attrs]: keyboards#km_core_keyboard_get_attrs "km_core_keyboard_get_attrs function"
 [km_core_keyboard_get_key_list]: keyboards#km_core_keyboard_get_key_list "km_core_keyboard_get_key_list function"

diff --git a/core/docs/api/keyboards.md b/core/docs/api/keyboards.md
@@ -106,8 +106,8 @@ typedef struct {
 
 ## Description
 
-Parse and load keyboard from the supplied blob and size and a pointer to the
-loaded keyboard into the out paramter.
+Parse and load a keyboard from the supplied blob and return a pointer to the
+loaded keyboard in the out parameter.
 
 ## Specification
 

diff --git a/core/tests/unit/km_core_keyboard_api.tests.cpp b/core/tests/unit/km_core_keyboard_api.tests.cpp
@@ -10,18 +10,6 @@
 
 km::core::path test_dir;
 
-// #if defined(__GNUC__) || defined(__clang__)
-// #define PRAGMA(X) _Pragma(#X)
-// #define DISABLE_WARNING_PUSH PRAGMA(GCC diagnostic push)
-// #define DISABLE_WARNING_POP PRAGMA(GCC diagnostic pop)
-// #define DISABLE_WARNING(W) PRAGMA(GCC diagnostic ignored #W)
-// #define DISABLE_WARNING_DEPRECATED_DECLARATIONS DISABLE_WARNING(-Wdeprecated-declarations)
-// #else
-// #define DISABLE_WARNING_PUSH
-// #define DISABLE_WARNING_POP
-// #define DISABLE_WARNING_DEPRECATED_DECLARATIONS
-// #endif
-
 class KmCoreKeyboardApiTests : public testing::Test {
 protected:
   km_core_keyboard* keyboard = nullptr;